Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name of simple-instance to vm-instance #252

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Change name of simple-instance to vm-instance #252

merged 1 commit into from
Apr 28, 2022

Conversation

heyealex
Copy link
Contributor

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

nick-stroud
nick-stroud approved these changes Apr 28, 2022
View reviewed changes
modules/README.md
@@ -13,11 +13,11 @@ module are listed in more detail below.

Compute

* **[simple-instance]** ![core-badge] : Creates one or more simple VM instances.
* **[vm-instance]** ![core-badge] : Creates one or more simple VM instances.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave it up to you ( @heyealex ) if we should run integration tests.

@nick-stroud nick-stroud assigned heyealex and unassigned nick-stroud Apr 28, 2022
@heyealex heyealex merged commit 0914924 into GoogleCloudPlatform:develop Apr 28, 2022
@heyealex heyealex deleted the refactor/vm-instance-name-change branch April 28, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@heyealex heyealex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyealex @nick-stroud